-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acts_as_list to Spree::StockLocation #2953
Add acts_as_list to Spree::StockLocation #2953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, is the position of StockLocation
s used anywhere in core currently?
Actually I realized that it doesn't look so... I bumped into this issue when trying to reorder the stock locations in the Admin (the UI still allows to do that, so maybe we should just remove that...). That also triggers a more interesting discussion: my original thought was that the stock locations ordering would be used in the simple shipment coordinator, but it's not. At least I think we should change |
I think you want to look at this recently merged PR #2783 that would allow to use the I think we need to merge this PR anyway since there's a bug in the UI. Thanks again! |
@kennyadsl Thanks for the pointer! That will fulfill my need perfectly! Looking forward for the next version! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@rymai would you mind to rebase with latest |
Fixes solidusio#2952. Signed-off-by: Rémy Coutable <remy@rymai.me>
d0f2200
to
fd22315
Compare
@tvdeyen Done, thanks! 🎉 |
Thank you for your contribution |
Fixes #2952.
/cc @octave